Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend construct_id_filter implementation with UniqueConstraint definitions #184

Open
maerteijn opened this issue Aug 26, 2019 · 1 comment
Open

Extend construct_id_filter implementation with UniqueConstraint definitions #184

maerteijn opened this issue Aug 26, 2019 · 1 comment
Labels
enhancement help wanted needs-investigation

Comments

@maerteijn
Copy link
Member

The current construct_id_filter implementation does not take the Django 2.2+ UniqueConstraint definitions into account.

This could become a problem when:

  • Oscar's unique_together constraints are converted to UniqueConstraints definitions
  • Custom models which don't rely on the base model when having own UniqueConstraints definitions
@maerteijn maerteijn changed the title Extend construct_id_filter to also check for Django 2.2+ UniqueConstraint Extend construct_id_filter implementation with UniqueConstraint definitions Aug 26, 2019
@Patil2099
Copy link
Contributor

@maerteijn Can I work on this issue? Also, Can You Explain what I have to do a bit more?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted needs-investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@specialunderwear @maerteijn @Patil2099