Implement productrecommendations #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscar_odin/mappings/context.py
Outdated
| fields = self.get_fields_to_update(relation.related_model) | ||
| if fields is not None: | ||
| validated_m2m_instances = self.validate_instances(instances) | ||
| relation.related_model.objects.bulk_create(validated_m2m_instances) | ||
| if relation.related_model != self.Model: |
There was a problem hiding this comment.
Can we assume that validate_resources is sufficient for product fields as this skips some custom clean methods of Product model?
There was a problem hiding this comment.
yes indeed I think so. For parents this was not an issue because of the structure (it tests different things) but for standalones they check if the title and slug are not none which we don't care about at this point.
Maybe we should only do this in the productmodelcontext and not in the normal modelcontext
like make it a settings on the context? What do you think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.