Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Trac timeline ticket_show_component #203

Closed
medmunds opened this issue Jun 28, 2024 · 5 comments
Closed

Enable Trac timeline ticket_show_component #203

medmunds opened this issue Jun 28, 2024 · 5 comments

Comments

@medmunds
Copy link

Would it be possible to enable Trac's [timeline] ticket_show_component configuration option?

This should include each ticket's "Component" in the Trac timeline. And hopefully would add component to the timeline RSS, allowing external monitoring of tickets for particular components.

See also #202 and forum discussion.

bmispelon added a commit to bmispelon/code.djangoproject.com that referenced this issue Jun 29, 2024
@bmispelon
Copy link
Member

Hi again 😄

I've created #205 and tested it locally. The way it works doesn't seem super ideal: all it does is that instead of showing the summary of a ticket, it shows {component} - {summary} (both in the HTML and the RSS versions). Would that still work for you?

@medmunds
Copy link
Author

Thanks for looking into this.

Although {component} - {summary} isn't as helpful as a separate component RSS field, it still seems like it would add useful information to the timeline. (And I could still hack together a component watcher on top of that. Though if #202 is an actual possibility, that would be my preference.)

That's assuming the whole summary is still shown. If adding the component results in truncating the summary in HTML view, that would probably be a step backwards.

If the timeline HTML view looks reasonable to you with this enabled, I'd say let's try it out. If any regular timeline users have a strong negative reaction, we can revert it.

@bmispelon
Copy link
Member

I've checked locally and the addition of the component doesn't trigger any extra truncation. Trac does truncate the summary to ~75 characters, but the truncation logic is done before prepending the component: https://github.com/edgewall/trac/blob/e011e2d023001fe6e17ca7bd83d30a96e6046cfa/trac/ticket/web_ui.py#L382-L385

I'm still going to attempt to fix #202, but in the meantime I'm also going to merge this as well, with the option to revert it if it's deemed to noisy.

I'll post an update here when the change is live.

@bmispelon
Copy link
Member

(it's live, though you might have to log in to see it since the timeline is heavily cached for anonymous users)

@medmunds
Copy link
Author

medmunds commented Jul 1, 2024

Nice, thanks. A search for (COMPONENT_NAME - (delimited with ( and -) finds everything for a particular component, in either the html timeline or the RSS <title> field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants