-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trac 1.4.4 #146
Update trac 1.4.4 #146
Conversation
4195ed3
to
8224a21
Compare
I applied |
8224a21
to
97b5181
Compare
PR rebased and ready to test (I also noticed and fixed a styling issue where the ticket box had lost its themed background color) |
EDIT Fixed now ✅ Just noticed something is wrong with the |
97b5181
to
5cd56a4
Compare
5cd56a4
to
c7b12be
Compare
Issue #141 will also be fixed by merging this |
I merged 4221609 because it's compatible with Trac 1.2.6. |
@bmispelon I'm looking at 39e46f7. Do you think we can remove these files in advance? i.e. is it compatible with 1.2.6? |
I'm not sure it's safe to delete all of them (looking at EDIT: Turns out that the deletion were maybe a bit hasty since some js was still used for the mobile version of the navitation, as well as loading some fonts that were used. See PR in next comment |
Here's a PR that removes the js files that were not used: #149 Once that one is merged, I'll rebase this one and resolve the conflicts that arise. |
This commit is enough to get the site up and running but doesn't contain any CSS fixes.
Also introduced a script that automatically generates the _noshadows.scss file to make it easier to update Trac.
c7b12be
to
e141b4c
Compare
Let's try, merged 💥 |
and deployed 🤞 |
Most of the work is from Florian's original PR: #133
In addition, I made the following changes:
<script>
tags in the html)box-shadow
scss reset, and created thenoshadows.py
script to automate that task. The script has some builtin tests when called with--tests
, not sure if it's worth adding those to CI too.Trac being trac, my local testing on a blank instance was limited but I think this PR is good enough to be merged. I'd like to continue the upgrade work once this is merged so we can finally move off Python 2 and Django 1.11 🧓🏻 .
Here are a few random tips that helped me test things locally:
trac.ini
(I usedlog_level = INFO
andlog_type = stderr
)[notification]
and[notification-subscriber]
sections intrac.ini
to avoid errors while sending emails after ticket creation/update