Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trac 1.4.4 #146

Closed
wants to merge 4 commits into from
Closed

Conversation

bmispelon
Copy link
Member

@bmispelon bmispelon commented Jan 13, 2024

Most of the work is from Florian's original PR: #133

In addition, I made the following changes:

  • removed warnings about missing js files (Florian deleted them but left the <script> tags in the html)
  • bumped version for Trac (1.4.4 instead of 1.4.3 and a slightly more recent version of the xmlrpc plugin)
  • fixed a styling issue with bold text in the navigation
  • updated the box-shadow scss reset, and created the noshadows.py script to automate that task. The script has some builtin tests when called with --tests, not sure if it's worth adding those to CI too.

Trac being trac, my local testing on a blank instance was limited but I think this PR is good enough to be merged. I'd like to continue the upgrade work once this is merged so we can finally move off Python 2 and Django 1.11 🧓🏻 .

Here are a few random tips that helped me test things locally:

  • turn on more verbose logging in trac.ini (I used log_level = INFO and log_type = stderr)
  • comment out the [notification] and [notification-subscriber] sections in trac.ini to avoid errors while sending emails after ticket creation/update

@felixxm
Copy link
Member

felixxm commented Jan 18, 2024

I applied black, please rebase.

@bmispelon
Copy link
Member Author

I applied black, please rebase.

PR rebased and ready to test (I also noticed and fixed a styling issue where the ticket box had lost its themed background color)

@bmispelon bmispelon mentioned this pull request Jan 18, 2024
4 tasks
@bmispelon bmispelon changed the title Update trac 1.4.4 [draft] Update trac 1.4.4 Jan 18, 2024
@bmispelon
Copy link
Member Author

bmispelon commented Jan 18, 2024

EDIT Fixed now ✅

Just noticed something is wrong with the noshadows.py script, it's not handling handling some selectors correctly and some bax-shadows are visible as a result (#mainnav for example). Working on it 🔨

@bmispelon bmispelon changed the title [draft] Update trac 1.4.4 Update trac 1.4.4 Jan 18, 2024
@bmispelon
Copy link
Member Author

Issue #141 will also be fixed by merging this

@felixxm
Copy link
Member

felixxm commented Jan 22, 2024

I merged 4221609 because it's compatible with Trac 1.2.6.

@felixxm
Copy link
Member

felixxm commented Jan 22, 2024

@bmispelon I'm looking at 39e46f7. Do you think we can remove these files in advance? i.e. is it compatible with 1.2.6?

@bmispelon
Copy link
Member Author

bmispelon commented Jan 22, 2024

@bmispelon I'm looking at 39e46f7. Do you think we can remove these files in advance? i.e. is it compatible with 1.2.6?

I'm not sure it's safe to delete all of them (looking at mobile-menu.js for example, it seems it's used to generate the navigation menu for the mobile version). I'm going to try and investigate which files are currently unused (or safe to delete) so we could minimize the diff. I'll keep you posted.

EDIT: Turns out that the deletion were maybe a bit hasty since some js was still used for the mobile version of the navitation, as well as loading some fonts that were used. See PR in next comment

@bmispelon bmispelon mentioned this pull request Jan 22, 2024
@bmispelon
Copy link
Member Author

Here's a PR that removes the js files that were not used: #149

Once that one is merged, I'll rebase this one and resolve the conflicts that arise.

apollo13 and others added 4 commits January 23, 2024 13:44
This commit is enough to get the site up and running but
doesn't contain any CSS fixes.
Also introduced a script that automatically generates the
_noshadows.scss file to make it easier to update Trac.
@bmispelon
Copy link
Member Author

@felixxm I've rebased this branch after the merging of #149 . I've taken the liberty to squash some commits together when I thought it made sense, I hope that's ok (if not let me know and I'll try to undo my git mess 😅 ). Hopefully that makes the reviewing easier.

@felixxm
Copy link
Member

felixxm commented Jan 24, 2024

Let's try, merged 💥

@felixxm felixxm closed this Jan 24, 2024
@felixxm
Copy link
Member

felixxm commented Jan 24, 2024

and deployed 🤞

@bmispelon bmispelon deleted the update-trac-1.4.4 branch January 25, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants