Fixed login/logout/logged as items in metanav #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the issues were caused by Trac's clever plugin system where classes implementing INavigationContributor all contribute to the metanav. Plugins can then override existing links by making sure they pass the same name (second element in the yielded tuple in get_navigation_items()). On top of that, trac.ini can override any item by specifying a <item name>.label configuration. Rather than trying to figure this all out, I've opted to hardcode the navigation menu in the HTML. This has the nice side-effect of removing the dependency on the forked trac-github. This commit therefore includes a revert of d8760ad. Fixes django#51
bmispelon
force-pushed
the
fix-metanav-login
branch
from
f4ebb1f
to
ef7da55
Compare
|
@bmispelon Fantastic 🚀 Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the issues were caused by Trac's clever plugin system where classes implementing
INavigationContributorall contribute to the metanav. Plugins can then override existing links by making sure they pass the same name (second element in the yielded tuple inget_navigation_items()). On top of that, trac.ini can override any item by specifying a .label configuration.Rather than trying to figure this all out, I've opted to hardcode the navigation menu in the HTML. This has the nice side-effect of removing the dependency on the forked trac-github.
This commit therefore includes a revert of d8760ad.
Fixes #51