Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format DSF text in copyright #177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

priyapahwa
Copy link

  • Add space between Software Foundation
  • Underline links for DSF & registered trademark

- Add space between Software Foundation
- Underline links for DSF & registered trademark

Signed-off-by: Priya Pahwa <pahwa.priya19@gmail.com>
@bmispelon bmispelon added the styling Issues that deal with styling label Feb 12, 2024
@bmispelon
Copy link
Member

Hi and thanks for the pull request!

I'm impressed you spotted the missing space in the footer, I didn't know anyone actually read that 😅

For the underlining, I would prefer to do it in CSS instead of using <u> in the HTML. That will require modifying the file at scss/trachacks.scss. I've done a quick check and it seems we have two options:

  1. Add the underline in the a:link, a:visited selector near the beginning. This undoes the styling that Trac does on all links where it removes the underline, but has the consequence that almost all links now have an underline on the page. Personally I don't mind, but it does affect a lot of pages.
  2. Add a more restricted selector, maybe something like .footer a, or even .footer .copyright a. This fixes the lack of underline in the footer only, but has the slight disadvantage that it's yet another customization of the style that ideally would be handled only be output.css (which we originally copied from django/djangoproject.com).

Do you have an opinion on what would be the better option of the two? Or maybe a third idea?

Thanks! ✨

@priyapahwa
Copy link
Author

Hey @bmispelon,
Thanks for the detailed feedback. I'll look into this and get back to you in a while :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
styling Issues that deal with styling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants