Added missing requirement for tracspamfilter plugin #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for tracking this down Baptiste. I'm surprised that the dependency is not listed in the https://trac.edgewall.org/browser/plugins/trunk/spam-filter/setup.py?rev=17752 |
|
Deployed 🤞 |
Same. I just filed an issue upstream: https://trac.edgewall.org/ticket/13742 Thanks for the quick turnaround on this! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating something else I happened to turn on logging in
trac.ini(changedlog_typetostdout) and saw this line in the console while running my local version:So it seems the cause for the latest spam waves might have been that one plugin was silently being skipped because of a missing dependency 😞
After installing the
filelockpackage the error goes away, which I assume means the plugin is active again 🤞🏻