Upgraded to Python 3.11 #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tim-schilling Thanks so much for the review, I can't believe I forgot about the 3.12 in the dockerfile 🤦🏻 I've added a few comments to address your other points, let me know if that makes sense now. I really appreciate your fresh perspective on this by the way. I've been steeping in this mess of old version and deprecations for several days now, to the point where I've internalized a lot. The questions you're asking are probably those I will have when I have to take a look at those files again a year from now, so it's good to clarify them now. |
tim-schilling
approved these changes
Nov 2, 2024
It does, thanks! Now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I wrote in #219 (comment), I think the best (well, least bad) option we have is to run Python 3.11.