Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added settings for control HTTP code of errored form #91

Closed
wants to merge 1 commit into from
Closed

Added settings for control HTTP code of errored form #91

wants to merge 1 commit into from

Conversation

ZuluPro
Copy link

@ZuluPro ZuluPro commented May 13, 2016

It could be useful ton control easily the HTTP code sent when the comment form is badly filled.

The app actually response a 200 (OK) which can sound bad for many devs. Some would like 400 or 422.

@claudep
Copy link
Member

claudep commented May 13, 2016

Thanks for the proposal but I don't think it's a good idea. When a form has an error, it should simply be redisplayed with the error messages, that's how forms are working most of the time. Hopefully, when issue #82 will be done, you should be able to subclass the comment post view and more easily customize the behavior if you need so.

@claudep claudep closed this May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants