Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1276: Add copy to clipboard icon for commands #1434

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

prashantpandey9
Copy link

@prashantpandey9 prashantpandey9 commented Nov 26, 2023

Screenshots for reference

Before:
image

After:

  • Light Theme (Windows):
    image

  • Light Theme (Linux/Mac)
    image

  • Dark Theme (Linux/Mac)
    image

  • Dark Theme (Windows)
    image

  • Copied Message
    image

@prashantpandey9 prashantpandey9 changed the title Fix #1276: Add copy to clipboard for commands Fix #1276: Add copy to clipboard icon for commands Nov 26, 2023
@sabderemane sabderemane self-requested a review November 26, 2023 19:37
@nvishnya
Copy link

nvishnya commented Dec 5, 2023

Commands for both Linux and Windows are copied no matter what tab is opened. Promts are also copied ($, ...>).
test

@prashantpandey9
Copy link
Author

prashantpandey9 commented Dec 6, 2023

hi @nvishnya Thanks for highlighting it. WIll check and try to improve this.

@prashantpandey9
Copy link
Author

Hi, updated the code copying logic refer below:

ezgif com-video-to-gif (2)

justify-content: space-between;

.btn-clipboard{
float: right;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have to use float here? You are using flexbox, I think it's better to keep everything in flex then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Click to copy text for commands present in the official Django website.
3 participants