Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded django-recaptcha to 4.0.0. #1440

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

sarahboyce
Copy link
Contributor

django-recaptcha 3.0.0 -> 4.0.0 to add Django 4.2 support
Migration guide: https://github.com/django-recaptcha/django-recaptcha/blob/main/CHANGELOG.md#400-2023-11-14

Impacted by renamed of captcha to django_recaptcha

Ref: #1437

@sarahboyce sarahboyce force-pushed the upgrade-django-recaptcha branch 2 times, most recently from a3c7c5b to fa4d947 Compare November 29, 2023 19:53
Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixxm
Copy link
Member

felixxm commented Dec 14, 2023

@sarahboyce Thanks 👍

@felixxm felixxm merged commit 2b7c3bb into django:main Dec 14, 2023
3 checks passed
@felixxm
Copy link
Member

felixxm commented Dec 14, 2023

I had to revert this change because it blocked making donations. Recaptcha token was no longer available here:

var recaptchaToken = document.getElementById('id_captcha').value;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants