Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Sphinx requirement with our RTD instance #1696

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

pauloxnet
Copy link
Member

Even though in Django pipelines we do not generate documentation but we only check typos, I remembered that we also generate documentation on RTD https://django.readthedocs.io

I verified that the builds run on Ubuntu 20.04 and Python 3.8
https://github.com/django/django/blob/main/.readthedocs.yml

You can see from the logs that the latest versions of Sphinx, docutils and babel compatible with Python 3.8 are installed
https://app.readthedocs.org/projects/django/builds/25876554/#246564223--78

For this reason I drafted the PR #1694 that is blocked by the Python 3.8 drop and opened this one that can be merged immediately since, from what already happens on RTD we already know that everything works well (in addition to the local tests)

@pauloxnet pauloxnet requested review from a team October 25, 2024 08:31
@bmispelon bmispelon removed the request for review from a team October 25, 2024 08:36
@bmispelon
Copy link
Member

Hi @pauloxnet, thanks for all the PRs you're sending lately ✨
Could you stop requesting reviews from the ops team unless it's strictly needed (it's generating a lot of notifications). For things like this one, I think asking the site maintainers is enough.

Thanks!

@pauloxnet
Copy link
Member Author

Hi @pauloxnet, thanks for all the PRs you're sending lately ✨ Could you stop requesting reviews from the ops team unless it's strictly needed (it's generating a lot of notifications). For things like this one, I think asking the site maintainers is enough.

Yes, of course, sorry for all the notifications.

Actually, when I tagged you I thought that PR was relevant for the ops team, but I will tag you only when strictly necessary.

To avoid further notifications, I take advantage of this comment to ask you what version of Debian/Ubuntu/Dockeriamge do we use for the website server?

@camilonova camilonova merged commit 913bc5d into django:main Oct 25, 2024
5 checks passed
@pauloxnet pauloxnet mentioned this pull request Oct 25, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants