Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ordered and fixed Makefile. #1697

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Ordered and fixed Makefile. #1697

merged 1 commit into from
Oct 25, 2024

Conversation

pauloxnet
Copy link
Member

I tried to order and fix the Makefile to help to work together with it, without modifying the behavior of the commands:

  • I alphabetically ordered all the commands
  • I changed the parameter names from the short-hands to long-hands
  • I added isort in the dev.txt requirements to fix make isort-check and make isort

Of course, I successfully run locally all the commands.

@pauloxnet pauloxnet requested a review from a team October 25, 2024 15:04
marksweb
marksweb approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very much approve of these types of files being setup alphabetically 👏🏼 👍🏼

@bmispelon bmispelon merged commit ca192a1 into django:main Oct 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pauloxnet @marksweb @bmispelon