-
-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a link to Individual membership in the site footer #1726
base: main
Are you sure you want to change the base?
Add a link to Individual membership in the site footer #1726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense, especially in light of #1461 as you pointed out.
Just have a small suggestion, looks good otherwise.
Thanks for taking the time for this! ✨
@bmispelon Thanks! Suggestion committed. |
Oops sorry, that url tag should have been Glad the tests caught that 😅 |
Finding information about Individual membership can be difficult if one does not already know where to look. The current path to this page from the homepage is via the footer at Learn More -> Django Software Foundation -> Individual Members. This change is in the same spirit as pull request django#1461, which added a link to the Corporate membership page in the footer for similar discoverability reasons.
97e2775
to
7b415ff
Compare
Updated and squashed into a single commit. Hopefully third time's the charm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested things locally and it works (tested both on the www
and docs
subdomains) 👍🏻
Would you mind filing another PR for the same change on (You'll have to hardcode the full URL there, as Thanks! 🚀 |
This is a companion change to go along with the footer updates made to the main djangoproject.com website at django/djangoproject.com#1726.
No problem, django/code.djangoproject.com#227 |
Finding information about Individual membership can be difficult if one does not already know where to look. The current path to this page from the homepage is via the footer at Learn More -> Django Software Foundation -> Individual Members. This change is in the same spirit as pull request #1461, which added a link to the Corporate membership page in the footer for similar discoverability reasons.