Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeat broken after first iteration #42

Closed
djeedai opened this issue Aug 3, 2022 · 2 comments · Fixed by #57 · May be fixed by #38
Closed

Repeat broken after first iteration #42

djeedai opened this issue Aug 3, 2022 · 2 comments · Fixed by #57 · May be fixed by #38
Labels
bug Something isn't working
Milestone
0.5.1

Comments

@djeedai
Copy link
Owner

djeedai commented Aug 3, 2022

Run any example (except menu currently broken due to #41) : the color animation goes from red to blue smoothly during the first loop, then from the second loop ping-pongs between full red and full blue without any interpolation.

@SUPERCILEX this is probably due to a bug in #19.

This is blocking #34
@djeedai djeedai added the bug Something isn't working label Aug 3, 2022
@djeedai djeedai added this to the Bevy 0.8 milestone Aug 3, 2022
@djeedai djeedai pinned this issue Aug 3, 2022
@SUPERCILEX
Copy link
Contributor

This isn't an issue in #38 so let's try to get that through. Probs one of the things I said would be broken in the intermediary, but lemme try and find the bug real quick to confirm.

@SUPERCILEX
Copy link
Contributor

Yeah, it's because progress is no longer bound to the 0,1 range and instead keeps increasing forever.

@SUPERCILEX SUPERCILEX mentioned this issue Aug 4, 2022
Open
@SUPERCILEX SUPERCILEX mentioned this issue Sep 24, 2022
Open
djeedai added a commit that referenced this issue Sep 27, 2022
@djeedai
Fix repeat mode broken after first iteration
7ec92b7 
Fix the repeat mode being broken after the first iteration due to
`AnimClock::progress()` reporting a progress greater than `1.`, which
was breaking the logic of `Tween` and `Lens`.

Fixes #42
@djeedai djeedai mentioned this issue Sep 27, 2022
Merged
djeedai added a commit that referenced this issue Sep 28, 2022
@djeedai
Fix repeat mode broken after first iteration (#57)
175c8b7 
Fix the repeat mode being broken after the first iteration due to
`AnimClock::progress()` reporting a progress greater than `1.`, which was
breaking the logic of `Tween` and `Lens`.

Also fix `Tween::rewind()` not restoring the original tween direction when
using a repeat strategy of `RepeatStrategy::MirroredRepeat`.

Fixes #42
@djeedai djeedai unpinned this issue Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.1
2 participants
@djeedai @SUPERCILEX