Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update savefile to version 0.16 #49

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

avl
Copy link
Contributor

@avl avl commented Jul 19, 2023

I've been running the benchmark a lot, and investigated why savefile didn't perform as well as some of the other libraries.

This proved very helpful, and I've realized that carrying a '&mut dyn Write' instead of making the serializer generic was very expensive. So, I've redesigned this aspect of Savefile, and done some more optimizations, and released version 0.16.

It is much faster!

It would be nice to have this new version in the benchmark!

@djkoloski djkoloski merged commit 59d6e96 into djkoloski:master Jul 19, 2023
@djkoloski
Copy link
Owner

Looks good, thanks for the PR!

@avl
Copy link
Contributor Author

avl commented Jul 20, 2023

I notice that the front-page has not yet updated. Is there a need to trigger some github action or something like that? Or did the benchmark run fail?

@djkoloski
Copy link
Owner

Thanks for pointing that out, I had the trigger for benchmarking set to branches: main, forgetting that this repo is relatively old and has a master branch instead. THat's been fixed and a new bench is underway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants