Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cbor4ii to benchmarks #56

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Conversation

quininer
Copy link
Contributor

:)

@djkoloski
Copy link
Owner

Looks like you just need to rerun cargo fmt. Make sure to pull first, I added one commit to pin the cbor4ii version to 0.3.1.

@quininer
Copy link
Contributor Author

quininer commented Nov 1, 2023

Since the old version of simd-json was revoked, I have to update it.

You may want to keep Cargo.lock to avoid this.

@djkoloski djkoloski merged commit 1a589b4 into djkoloski:master Nov 1, 2023
1 check passed
@djkoloski
Copy link
Owner

Thanks for the PR! Sorry about broken CI, I did a quick pass to fix that up.

@quininer quininer deleted the add-cbor4ii branch November 1, 2023 13:58
@djkoloski
Copy link
Owner

The regex for parsing log outputs wasn't matching crates with numbers in their names. I've fixed that and stats for cbor4ii now appear in the README.

@quininer
Copy link
Contributor Author

quininer commented Nov 2, 2023

The results look worse than I expected, cbor4ii performs better than serde_cbor on all my test devices (amd, intel, aarch64), but not on github actions.

@djkoloski
Copy link
Owner

Are you testing with these benchmarks or another set of benchmarks?

@quininer
Copy link
Contributor Author

quininer commented Nov 2, 2023

Using this benchmark, my local first bench can get a score of 700us before submit, but only 1.3ms after merge.

20231102-120704
^ before submit

Screenshot_20231102_121252
^ after merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants