Added Bincode2 #61
Merged
Added Bincode2 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I had to change a few things very slightly and add support for multiple packages to our CI process. Benches should be updated automatically after the post-commit check finishes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bincode 2 is currently in RC and as I found it to be much faster than Bincode 1, I am adding it as a separate benchmark here. This could very well remain the use case in the future as both, bincode 1 and 2 will have to be supported by the maintainers for backwards compatibility since the format changed.
Currently, there is an issue with the crate that it can only be imported as "bincode", so bincode version 1 had to be renamed to "bincode1" and bincode version 2 has to be called "bincode".