-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrections to prost benchmark #62
Conversation
Looks like there's a new issue with nightlies related to aHash 0.7. I'll try to update bson-rust to the latest version since that would eliminate the old dependency. |
… of the "logs" bench More serializers should be forced to check this! the data they serialized should be fully recoverable!
this significantly slows its encoding in this bench and increases its encoded/compressed size by 15/38%
I can't get an unrestricted set of features to work no matter what i install, flatbuffer generated files are totally wrong with the tool i get in ubuntu 22.04 & 23.10. that's a separate problem though |
What issues are you seeing? Are they related to the generated Rust files? |
i get at least 11 errors like
probable issue:
...but it's kind of a big workflow pain to need to go get and install the latest one to run this, especially considering there are already generated files checked in that it just wants to stomp. the repo won't build until i install both |
Yeah that's been a problem for a while. As an immediate-term fix you could just disable the |
here's a mini-kludge for it that should work: #63 |
The
prost
benchmark is currently discarding theLog::address
field, causing it to appear to have significantly higher performance and better compactness than it should.Before:
After:
I also added guardrails to the other benches as well, but this is the main one that it appeared to be performing far better than possible. It is successfully round-tripping values in the other benches.