Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wiring size #81

Merged
merged 1 commit into from
May 5, 2024
Merged

Fix wiring size #81

merged 1 commit into from
May 5, 2024

Conversation

caibear
Copy link
Contributor

@caibear caibear commented May 5, 2024

The buffer wasn't being cleared before serializing again to measure size. As a result the size benchmarks were twice as high as they should have been.

@djkoloski djkoloski merged commit 24c07e6 into djkoloski:master May 5, 2024
1 check passed
@djkoloski
Copy link
Owner

Thanks for noticing, something related came up on the original PR but this one got overlooked.

@caibear caibear deleted the fix_wiring_size branch May 5, 2024 14:17
@louaykamel
Copy link
Contributor

My apologies for the oversight. I became aware of the issue some time ago and have been mindful not to inundate the repository. A fix was scheduled for inclusion in my forthcoming PR, coinciding with the next release.
Additionally, it’s worth noting that the benchmark results on my Intel machine have shown a notable variance, which is quite intriguing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants