Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build&ci): update bytemuck up to 1.18.0 to avoid missing 1.16.1 version #87

Closed
wants to merge 2 commits into from
Closed

fix(build&ci): update bytemuck up to 1.18.0 to avoid missing 1.16.1 version #87

wants to merge 2 commits into from

Conversation

kitsuniru
Copy link
Contributor

No description provided.

@kitsuniru kitsuniru changed the title fix: update bytemuck up to 1.18.0 to avoid missing 1.16.1 version fix(build&ci): update bytemuck up to 1.18.0 to avoid missing 1.16.1 version Sep 8, 2024
@djkoloski
Copy link
Owner

This works, but can we just leave bytemuck without an explicit version? I don't think it's a direct dependency of the benchmarks. I think it's only an indirect dependency, which we shouldn't specify a version requirement for.

@kitsuniru
Copy link
Contributor Author

@djkoloski fixed, u can merge it

@djkoloski
Copy link
Owner

I ended up removing bytemuck from the dependency list entirely

@djkoloski djkoloski closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djkoloski djkoloski djkoloski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitsuniru @djkoloski