Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Memorize window size #5

Open
egoist opened this issue Nov 2, 2018 · 4 comments
Open

Feature request: Memorize window size #5

egoist opened this issue Nov 2, 2018 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@egoist
Copy link
Contributor

egoist commented Nov 2, 2018

https://github.com/GoogleChromeLabs/carlo/blob/master/API.md#launchoptions

Carlo accepts app width and height so we can memorize window size on resizing and restore size when creating the app.
@djyde
Copy link
Owner

djyde commented Nov 2, 2018 •
edited
Loading

Where to store the preferences data. ${HOME}/.koy or somewhere else?

@egoist
Copy link
Contributor Author

egoist commented Nov 2, 2018

Just use https://github.com/sindresorhus/conf

@djyde
Copy link
Owner

djyde commented Nov 2, 2018

I found it's hard to implement because there is no beforeClose hook on puppeteer page instance.

@egoist
Copy link
Contributor Author

egoist commented Nov 4, 2018

does window.onbeforeunload work?

@djyde djyde added enhancement New feature or request help wanted Extra attention is needed labels Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djyde @egoist