Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'For anyone else' reminder about adding reactions #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions source/dlangbot/github.d
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ Bear in mind that large or tricky changes may require multiple rounds of review

Please see [CONTRIBUTING.md](https://github.com/%s/blob/master/CONTRIBUTING.md) for more information.`,
pr.user.login, pr.repoSlug);

}

static immutable bugzillaReferences = ["dlang/dmd", "dlang/druntime", "dlang/phobos",
Expand All @@ -90,6 +91,12 @@ If your PR contains non-trivial changes, please [reference a Bugzilla issue](htt
app ~= "### ⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️\n\n";
app.printMessages(msgs);
}
app.put(`
### For anyone else

Reactions help us determine how many people are interested in a pull request or have run across a similar bug. Please leave a +1 reaction (:+1:) if that applies to you. Any additional details you can provide, such as your usecase, environment, steps to reproduce, or workarounds you have found, can help out with getting pull requests merged.
You don't need merge permissions to review a pull request. Review the diff and point out problematic bits you did encounter.`);

return app.data;
}

Expand Down