Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve logic in isCopyConstructable() #16929

Merged
merged 1 commit into from
Oct 5, 2024
Merged

improve logic in isCopyConstructable() #16929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions compiler/src/dmd/typesem.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,37 +905,41 @@ private extern(D) bool isCopyConstructorCallable (StructDeclaration argStruct,
*/
OutBuffer buf;
auto callExp = e.isCallExp();
void nocpctor()

bool nocpctor()
{
buf.printf("`struct %s` does not define a copy constructor for `%s` to `%s` copies",
argStruct.toChars(), arg.type.toChars(), tprm.toChars());
}
auto f = callExp.f;
if (!f)
{
nocpctor();
*pMessage = buf.extractChars();
return false;
}
char[] s;
if (!f.isPure && sc.func.setImpure())
s ~= "pure ";
if (!f.isSafe() && !f.isTrusted() && sc.setUnsafe())
s ~= "@safe ";
if (!f.isNogc && sc.func.setGC(arg.loc, null))
s ~= "nogc ";

auto f = callExp.f;
if (!f)
return nocpctor();

if (f.isDisabled() && !f.isGenerated())
{
/* https://issues.dlang.org/show_bug.cgi?id=24301
* Copy constructor is explicitly disabled
*/
buf.printf("`%s` copy constructor cannot be used because it is annotated with `@disable`",
f.type.toChars());
*pMessage = buf.extractChars();
return false;
}
else if (s)

bool bpure = !f.isPure && sc.func.setImpure();
bool bsafe = !f.isSafe() && !f.isTrusted() && sc.setUnsafe();
bool bnogc = !f.isNogc && sc.func.setGC(arg.loc, null);
if (bpure | bsafe | bnogc)
{
s[$-1] = '\0';
buf.printf("`%s` copy constructor cannot be called from a `%s` context", f.type.toChars(), s.ptr);
const nullptr = "".ptr;
buf.printf("`%s` copy constructor cannot be called from a `%s%s%s` context",
f.type.toChars(),
bpure ? "pure " .ptr : nullptr,
bsafe ? "@safe ".ptr : nullptr,
bnogc ? "nogc" .ptr : nullptr);
}
else if (f.isGenerated() && f.isDisabled())
{
Expand All @@ -951,7 +955,7 @@ private extern(D) bool isCopyConstructorCallable (StructDeclaration argStruct,
* i.e: `inout` constructor creates `const` object, not mutable.
* Fallback to using the original generic error before https://issues.dlang.org/show_bug.cgi?id=22202.
*/
nocpctor();
return nocpctor();
}

*pMessage = buf.extractChars();
Expand Down
Loading