Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[declaration.d] move checkDisabled and expandInitializer to expre… #16941

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

thewilsonator
Copy link
Contributor

…ssionsem.d

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16941"

@dkorpel
Copy link
Contributor

dkorpel commented Oct 6, 2024

Considering the functions act on declarations and not expressions, why expressionsem and not dsymbolsem?

@thewilsonator
Copy link
Contributor Author

There are no uses in dsymbolsem.d.
There is a single use in funcsem.d that should be removed very soon for the deprecation period for the removal of the delete keyword https://github.com/dlang/dmd/blob/master/compiler/src/dmd/funcsem.d#L1652

There are 8 uses in expressionsem.d and 3 in typesem.d, so I went with expressionsem.d.

@thewilsonator thewilsonator merged commit 62566ef into dlang:master Oct 6, 2024
41 checks passed
@thewilsonator thewilsonator deleted the move-declaration branch October 6, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants