Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isCopyConstructable should call isCopyable #16944

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WalterBright
Copy link
Member

Seeing if this can be done.

@WalterBright WalterBright added the Refactoring No semantic changes to code label Oct 5, 2024
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16944"

@WalterBright WalterBright force-pushed the isCopyCtor branch 2 times, most recently from f39572d to 3258406 Compare October 6, 2024 00:19
@WalterBright
Copy link
Member Author

This fails to compile libmir with:

source/mir/rc/ptr.d(395,15): Error: `mir.rc.ptr.castTo` called with argument types `(mir_rcptr!(C))` matches both:
  source/mir/rc/ptr.d(275,13):     `mir.rc.ptr.castTo!(I, C).castTo(mir_rcptr!(C) context)`
  and:
  source/mir/rc/ptr.d(291,25):     `mir.rc.ptr.castTo!(I, C).castTo(immutable(mir_rcptr!(C)) context)`

@WalterBright WalterBright force-pushed the isCopyCtor branch 2 times, most recently from b79cee9 to 970bc05 Compare October 6, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring No semantic changes to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants