Add autoGamma, autoLevel and gaussianBlur to MagickImage. #150
Conversation
|
Can you rebase this PR so we can run the tests? And thanks for splitting the PR up so those new methods are added individually. Otherwise I would have asked to split this PR up. |
|
And you also got some linting issues. Please update the individual commits or create separate PR's. |
Peeterush
force-pushed
the
add-features
branch
from
46c5b23 to
801e7e9
Compare
|
Oops! I accidentally had ESLint disabled in my IDE. All good now! |
| * Gaussian blur image. | ||
| * @param radius - The number of neighbor pixels to be included in the convolution. | ||
| */ | ||
| gaussianBlur(radius: number): void; |
There was a problem hiding this comment.
The Magick.NET library also has a (radius: number, channels: Channels) overload. Can this also be added?
There was a problem hiding this comment.
This is the issue I described in #151. But we can't use the same trick here, as it collides with (radius: number, sigma: number). If you can think of another way I'll happily implement it.
There was a problem hiding this comment.
For an other method I made the channels argument the first argument but that is also not a really clean solution that I should probably revert. And that will also not work here.
Peeterush
force-pushed
the
add-features
branch
2 times, most recently
from
b97f65c to
50aa8b2
Compare
Peeterush
force-pushed
the
add-features
branch
from
50aa8b2 to
9698e16
Compare
gaussianBlur(radius: number, channels: Channels): void;was omitted as there is no way to distinguish it fromgaussianBlur(radius: number, sigma: number): void;