Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library shouldn't attempt to configure bluebird #27

Open
gavinsharp opened this issue Nov 7, 2018 · 1 comment
Open

library shouldn't attempt to configure bluebird #27

gavinsharp opened this issue Nov 7, 2018 · 1 comment

Comments

@gavinsharp
Copy link

When trying to test a simple query, I got:
Error: cannot enable long stack traces after promises have been created

This exception was thrown by bluebird because my app created a promise before calling into node-redshift.

I eventually figured out I could work around this by passing { longStackTraces: false }, but I think that shouldn't be necessary - it's not uncommon for apps to be using promises elsewhere. I suggest making the default value of longStackTraces false, or removing it as an option altogether (library consumers can call Promise.config themselves if desired).

@gavinsharp
Copy link
Author

Oh and thanks for the very useful library, by the way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant