Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to fix hardcoded PATH's and remove extra variable #18

Open
dmytro opened this issue Jun 30, 2015 · 2 comments
Open

Need to fix hardcoded PATH's and remove extra variable #18

dmytro opened this issue Jun 30, 2015 · 2 comments

Comments

@dmytro
Copy link
Owner

dmytro commented Jun 30, 2015

@zentahori

I'd like you to work on fixing small issues with recipes.

  1. Following lines have hardcoded path's in it:
    https://github.com/dmytro/capistrano-recipes/pull/10/files#diff-58ce518092f6be150736b33edd66d7e4R16,
    https://github.com/dmytro/capistrano-recipes/pull/10/files#diff-58ce518092f6be150736b33edd66d7e4R21
  2. Ideally I'd want to find a way to remove variable config_sub_dir, it's too specific to CMS deployment. https://github.com/dmytro/capistrano-recipes/pull/10/files#diff-b018874641b85dcd2cf07ae96e5596c4R153

If there's no way to remove it completely it should be moved to CMS configuration, but definitely it's setting should not be in base.rb.

If it's too difficult to make generic recipe, then we should move it to local_recipes.

@dmytro
Copy link
Owner Author

dmytro commented Jun 30, 2015

@zentahori

@zentahori
Copy link
Collaborator

  • It is easier to avoid the hardcoded path regarding No1.
    • #{ghost_content_path}#{config_sub_dir} will be the final path that we want.
  • I have no better solution as to how to remove variable config_sub_dir right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants