Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SnapLayout Options support for Win11 #345

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

SlimeNull
Copy link

Add SnapLayout Options support for Win11

image

@ElektroKill
Copy link
Member

Hello,

Sorry for the late response.

I like the idea of adding the support for the Win 11 snap layout feature, however, I'd prefer if this was directly integrated into dnSpy code base. I do not want to depend on additional WPF dependencies.

If this can be done cleanly and cleanly integrated into dnSpy codebase, I'm all for such a change. Please let me know if you are willing to undergo this change.

@SlimeNull
Copy link
Author

OK, I'll copy the code directly into the dnSpy repository so that it doesn't have to reference the library.

Copy link
Member

@ElektroKill ElektroKill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the code style issues I mentioned in the review, furthermore, would it be possible to isolate the code required for the Snap layouts features and remove the code for other features like rounded corners (already implemented in dnSpy) and others like backdrop, caption styling, etc? preferably the PR should include only the code necessary for the snaplayouts feature. It will make the code much easier to read as it will only contain the necessary logic!

Let me know what you think of these suggestions.

@SlimeNull
Copy link
Author

Fixed : )

@SlimeNull
Copy link
Author

If there's anything else you'd like to change, please let me know.

@ElektroKill ElektroKill merged commit f1e4fcb into dnSpyEx:master Aug 7, 2024
3 checks passed
@ElektroKill
Copy link
Member

Thanks!

@ElektroKill ElektroKill added this to the vNext milestone Aug 7, 2024
@ElektroKill ElektroKill added the enhancement New feature or request label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants