Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿš‘ fix: ErrorBoundary ๋†’์ด 100svh๋กœ ์ˆ˜์ • #294

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

easyhyun00
Copy link
Collaborator

๐Ÿงฉ ์ด์Šˆ ๋ฒˆํ˜ธ

โœ… ์ž‘์—… ์‚ฌํ•ญ

ErrorBoundary container ๋†’์ด๋ฅผ 100% ์—์„œ 100svh๋กœ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

[๊ธฐ์กด]

image

[๋ณ€๊ฒฝ ํ›„]

image image

๐Ÿ‘ฉโ€๐Ÿ’ป ๊ณต์œ  ํฌ์ธํŠธ ๋ฐ ๋…ผ์˜ ์‚ฌํ•ญ

@easyhyun00 easyhyun00 added the ๐Ÿš‘ Hotfix ๋ฒ„๊ทธ ์ˆ˜์ • label Apr 17, 2024
@easyhyun00 easyhyun00 self-assigned this Apr 17, 2024
@easyhyun00 easyhyun00 requested a review from bbearcookie as a code owner April 17, 2024 12:05
Copy link

๐Ÿš€ Storybook Preview ๋ณด๋Ÿฌ๊ฐ€๊ธฐ: https://65a6c73d536a3c43b7c5c9bb-ajidkyuwow.chromatic.com/
โฐ ๋ฐฐํฌ ์ผ์‹œ: Wed Apr 17 2024 21:06:27 GMT+0900

Copy link

๐ŸŽฎ React Preview ๋ณด๋Ÿฌ๊ฐ€๊ธฐ: https://dnd-10th-4-frontend-q328wpvcm-bbearcookies-projects.vercel.app
โฐ ๋ฐฐํฌ ์ผ์‹œ: Wed Apr 17 2024 21:06:33 GMT+0900

Copy link
Member

@bbearcookie bbearcookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•—! ์š”๋Ÿฐ ๋ฌธ์ œ๊ฐ€ ์žˆ์—ˆ๊ตฐ์š” ๐Ÿ˜…
๊ณ ์ƒํ•˜์…จ์–ด์š”!!

@easyhyun00 easyhyun00 merged commit 3aca79c into main Apr 18, 2024
7 checks passed
@easyhyun00 easyhyun00 deleted the fix/#293/errorboundary-height branch April 18, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿš‘ Hotfix ๋ฒ„๊ทธ ์ˆ˜์ •
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ErrorBoundary ํ™”๋ฉด ๋†’์ด ์ˆ˜์ •
2 participants