Refactor: OauthService 회원 가입, 로그인, 탈퇴 시 Oauth id token, access token 요청/응답과 db 트랜잭션 분리 #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WonSteps
force-pushed
the
refactor#275/oauth-transaction
branch
from
e16b4ff to
44404ea
Compare
hee9841
changed the title
WonSteps
force-pushed
the
refactor#275/oauth-transaction
branch
from
44404ea to
38ef7a1
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 이슈 연결
🚀 구현한 API
💡 반영할 내용 및 변경 사항 요약
OauthService에서 socialProfile 생성 로직을SocialProfileService로 분리합니다. 113698aSignupEvent,WithdrawEvent를 발생하도록 수정해MemberEventHandler컴포넌트에서 각각 처리하도록 합니다.🔍 리뷰 요청/참고 사항
SignupEvent가 발생하면BadgeEventHandler에서 해당 멤버에게 배지를 부여하도록 고려중이에요