#12 feat: Sign in with Apple #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
์ ํ ์๋ฒ์์ ๋ฐ์ ์จ jwk ๊ฒ์ฆ, ์ ๋ณด ์ถ์ถ ๊ตฌํ
Apple ๋ก๊ทธ์ธ ๊ตฌํ์ ํ์ํ ์ธ์ฆํ ํฐ ๊ด๋ จ ๋ด์ฉ ์ถ๊ฐ
Access Token, Refresh Token ๋ฐ๊ธ ์๋ฃ
Closed
์์ง ํ์ ์์ฑ ์ผ์, ์ญ์ ์ผ์๋ ์ฐ์ด์ง ์์์ ์ง์๋๋ค~
youngreal
requested changes
Aug 17, 2024
src/main/java/com/dnd/dndtravel/auth/controller/AuthTokenController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dnd/dndtravel/auth/controller/AuthTokenController.java
Outdated
Show resolved
Hide resolved
Comment on lines
1
to
16
| package com.dnd.dndtravel.auth.dto.request; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| public class AppleLoginRequest { | ||
|
|
||
| private final String appleToken; | ||
|
|
||
| @JsonCreator | ||
| public AppleLoginRequest(@JsonProperty("appleToken")final String appleToken) { | ||
| this.appleToken = appleToken; | ||
| } | ||
| } |
There was a problem hiding this comment.
- DTO๋ค์ Record ๋ฅผ ์ฌ์ฉํ์ ๋ ๋ ๊ฒ๊ฐ์์. ๋ฐ๋์ ์จ์ผํ๋๊ฑด ์๋์ง๋ง ์ด๋ฏธ ์ ๋ก๋๋ ์ฝ๋๋ค์์ Record๋ฅผ ์ฌ์ฉํ๊ณ ์์ผ๋, ํต์ผํ๋๊ฒ ์ข์๋ณด์ ๋๋ค.
- @JSonCreator์ @JsonProperty๊ฐ ๊ผญ ํ์ํ ๊น์? ์ ๋ ๋ถํ์ํ ์ฝ๋๋ผ๊ณ ๋ณด์ฌ์ง๋๋ค.
- appleToken์ ์ ํจ์ฑ ๊ฒ์ฌ๊ฐ ํ์ํ์ง์์๊น์? null์ด๋ ์ด์ํ๊ฐ์ด ๋ค์ด์จ๋ค๋ฉด..?
Comment on lines
33
to
35
| throw new RuntimeException("appleToken ๊ฐ์ด jwt ํ์์ธ์ง, ๊ฐ์ด ์ ์์ ์ธ์ง ํ์ธํด์ฃผ์ธ์."); | ||
| } catch (JsonProcessingException e) { | ||
| throw new RuntimeException("๋์ฝ๋๋ ํค๋๋ฅผ Map ํํ๋ก ๋ถ๋ฅํ ์ ์์ต๋๋ค. ํค๋๋ฅผ ํ์ธํด์ฃผ์ธ์."); |
There was a problem hiding this comment.
Runtime์์ธ๊ฐ ์๋ Custom ์์ธ๋ฅผ ๋์ ธ์ค ํ์๊ฐ์๊ฒ ๋ค์ ใ ใ
Comment on lines
29
to
31
| public boolean isSameKid(final String kid) { | ||
| return this.kid.equals(kid); | ||
| } |
There was a problem hiding this comment.
kid์ ๋ํ ๋ค์ด๋ฐ ๊ณ ๋ฏผ ํ์ํด๋ณด์ ๋๋ค
MemberId๊ฐ ๋ด๊ธด Access Token ์์ฑ, JWT_SECRET_KEY ์ถ๊ฐ
apple ํจํค์ง, auth์ dto ํจํค์ง ์ด๋
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? ๐
Changes ๐
Screenshot ๐ท