fix(cache): remove entry from _pending in case of exception #1048
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If an exception is thrown during
loader
execution - future with error result will be stuck in the_pending
map and it will be returned every timeputIfAbsent
is called. There is no way to evict it either, sinceevict
method only affects_cache
map.The exception in loader may be thrown in case of network error when
SvgNetworkLoader
is used.Change
This change adds a
catchError
handler to remove future from the_pending
map in case of failure. Also a regression test is added that will fail without this fix.