Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling enhancement #1104

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

minhhung2556
Copy link

Title

Error handling when loading and parsing SVG files.

Purpose

This PR is related to dnfield/vector_graphics#258, which will fix some related issues:
dnfield/vector_graphics#219
#1100
#1085
#1080
#1044
#996
#1007

Changes Made

  • catch error cases and return results to SVGPicture.
  • expose errorWidgetBuilder.

Testing

  • Already tested by example and unit test in flutter_svg

Impact

This change should not affect other parts of the library.

@zanderso
Copy link
Contributor

zanderso commented Nov 1, 2024

Hi there, The Flutter team is now maintaining this package in the flutter/packages repository at this location. We'd appreciate it if you could direct this PR to that location instead. Thanks!

minhhung2556 added a commit to minhhung2556/flutter-packages that referenced this pull request Nov 4, 2024
minhhung2556 added a commit to minhhung2556/flutter-packages that referenced this pull request Nov 4, 2024
@minhhung2556
Copy link
Author

Hi @zanderso
Here is my PR to flutter/packages.
Thanks for your response.

minhhung2556 added a commit to minhhung2556/flutter-packages that referenced this pull request Nov 4, 2024
minhhung2556 added a commit to minhhung2556/flutter-packages that referenced this pull request Nov 4, 2024
minhhung2556 added a commit to minhhung2556/flutter-packages that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants