Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/js/go: resolve('dnslink.dev/abcd?foo=bar') should error #32

Open
lidel opened this issue Aug 3, 2021 · 1 comment
Open

test/js/go: resolve('dnslink.dev/abcd?foo=bar') should error #32

lidel opened this issue Aug 3, 2021 · 1 comment
Assignees
Labels
P3 Low: Not priority right now

Comments

@lidel
Copy link
Contributor

lidel commented Aug 3, 2021

Concern

Allowing arbitrary strings is leaky: mixes DNS names with protocol/application-specific paths.
We should be more strict here.

Ask

return "invalid FQDN" error when invalid FQDN is passed to resolve methods

@lidel lidel changed the title resolveN('dnslink.dev/abcd?foo=bar') should error test/js/go: resolveN('dnslink.dev/abcd?foo=bar') should error Aug 3, 2021
@lidel lidel transferred this issue from dnslink-std/js Aug 3, 2021
@lidel lidel added the P3 Low: Not priority right now label Aug 3, 2021
@martinheidegger martinheidegger changed the title test/js/go: resolveN('dnslink.dev/abcd?foo=bar') should error test/js/go: resolve('dnslink.dev/abcd?foo=bar') should error Aug 22, 2021
@martinheidegger
Copy link
Contributor

The behavior in the current releases of js/go is that they pass the domain without extensive pre-processing to the DNS servers, which will will cause a NXDomain error like:

Error: Non-Existent Domain. (rcode=3, error=NXDomain, question={"question":{"type":"TXT","name":"website.ipfs.io?foo=bar"}})

Is this sufficient to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low: Not priority right now
Projects
None yet
Development

No branches or pull requests

2 participants