Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Server 2025 to allowed external pins #18143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

This comment has been minimized.

@tianon
Copy link
Member Author

tianon commented Jan 8, 2025

Arguably, we should also be removing ltsc2019 / 1809 🤔

https://learn.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/base-image-lifecycle (end of mainstream support was "01/09/2024")

@tianon
Copy link
Member Author

tianon commented Jan 10, 2025

Arguably, we should also be removing ltsc2019 / 1809 🤔

https://learn.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/base-image-lifecycle (end of mainstream support was "01/09/2024")

The "extended support" is legit though, so I think we should maybe pick a project like GHA to mirror here and keep support for 2019 roughly as long as they do (they dropped 2016 - actions/runner-images#5994, which is also still in extended support mode).

@tianon
Copy link
Member Author

tianon commented Jan 18, 2025

Rebased, updated pins to latest, updated to bashbrew 0.1.13 (for docker-library/bashbrew#112)

@tianon tianon marked this pull request as ready for review January 18, 2025 00:59
@tianon tianon requested a review from a team as a code owner January 18, 2025 00:59
Copy link

Diff for 6c54eda:
diff --git a/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/bashbrew.json b/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/bashbrew.json
new file mode 100644
index 0000000..531fca5
--- /dev/null
+++ b/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/bashbrew.json
@@ -0,0 +1,22 @@
+{
+	"arches": {
+		"windows-amd64": [
+			{
+				"digest": "sha256:706a6fa7d39d62f4087963a9dfd20f4579d2f7361594a4f642da60c9b0f54356",
+				"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
+				"platform": {
+					"architecture": "amd64",
+					"os": "windows",
+					"os.version": "10.0.26100.2894"
+				},
+				"size": 429
+			}
+		]
+	},
+	"desc": {
+		"digest": "sha256:d584aae93e84d61c8a3280ed3a5d5a6d397c0214a2902acadb8b17b0b00c70e8",
+		"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
+		"size": 350
+	},
+	"ref": "mcr.microsoft.com/windows/nanoserver:ltsc2025@sha256:d584aae93e84d61c8a3280ed3a5d5a6d397c0214a2902acadb8b17b0b00c70e8"
+}
diff --git a/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_706a6fa7d39d62f4087963a9dfd20f4579d2f7361594a4f642da60c9b0f54356-config.json b/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_706a6fa7d39d62f4087963a9dfd20f4579d2f7361594a4f642da60c9b0f54356-config.json
new file mode 100644
index 0000000..f40f6f3
--- /dev/null
+++ b/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_706a6fa7d39d62f4087963a9dfd20f4579d2f7361594a4f642da60c9b0f54356-config.json
@@ -0,0 +1,39 @@
+{
+	"architecture": "amd64",
+	"config": {
+		"AttachStderr": false,
+		"AttachStdin": false,
+		"AttachStdout": false,
+		"Cmd": [
+			"c:\\windows\\system32\\cmd.exe"
+		],
+		"Domainname": "",
+		"Entrypoint": null,
+		"Env": null,
+		"Hostname": "",
+		"Image": "",
+		"Labels": null,
+		"OnBuild": null,
+		"OpenStdin": false,
+		"StdinOnce": false,
+		"Tty": false,
+		"User": "ContainerUser",
+		"Volumes": null,
+		"WorkingDir": ""
+	},
+	"created": "2025-01-13T02:49:59.9749213Z",
+	"history": [
+		{
+			"created": "2025-01-13T02:49:59.9749213Z",
+			"created_by": "Apply image 10.0.26100.2894"
+		}
+	],
+	"os": "windows",
+	"os.version": "10.0.26100.2894",
+	"rootfs": {
+		"diff_ids": [
+			"sha256:15b8f3150725715e784897c6f3b867f9a4f310eec8c2ac41cd97004bd7a69640"
+		],
+		"type": "layers"
+	}
+}
diff --git a/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_706a6fa7d39d62f4087963a9dfd20f4579d2f7361594a4f642da60c9b0f54356.json b/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_706a6fa7d39d62f4087963a9dfd20f4579d2f7361594a4f642da60c9b0f54356.json
new file mode 100644
index 0000000..9cf40c2
--- /dev/null
+++ b/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_706a6fa7d39d62f4087963a9dfd20f4579d2f7361594a4f642da60c9b0f54356.json
@@ -0,0 +1,16 @@
+{
+	"config": {
+		"digest": "sha256:9d0196791c1c8c96145b0fa04e3ee4c1a3ca8bf26727dad93edfc56b80129665",
+		"mediaType": "application/vnd.docker.container.image.v1+json",
+		"size": 638
+	},
+	"layers": [
+		{
+			"digest": "sha256:a3c186345058f6f1d0536c64201b932a82e2c620edf75e054435d7ca6a3ed675",
+			"mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
+			"size": 193303215
+		}
+	],
+	"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
+	"schemaVersion": 2
+}
diff --git a/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/bashbrew.json b/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/bashbrew.json
new file mode 100644
index 0000000..06e511b
--- /dev/null
+++ b/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/bashbrew.json
@@ -0,0 +1,25 @@
+{
+	"arches": {
+		"windows-amd64": [
+			{
+				"digest": "sha256:da20c9f897d4e5648048577a5c21d81d1237d2f734c0692b987fd000b3245f28",
+				"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
+				"platform": {
+					"architecture": "amd64",
+					"os": "windows",
+					"os.features": [
+						"win32k"
+					],
+					"os.version": "10.0.26100.2894"
+				},
+				"size": 596
+			}
+		]
+	},
+	"desc": {
+		"digest": "sha256:f6153b44882e7ada8fa17123cfca1da3f29ea7fbe062c9e931240dc837aa4256",
+		"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
+		"size": 375
+	},
+	"ref": "mcr.microsoft.com/windows/servercore:ltsc2025@sha256:f6153b44882e7ada8fa17123cfca1da3f29ea7fbe062c9e931240dc837aa4256"
+}
diff --git a/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_da20c9f897d4e5648048577a5c21d81d1237d2f734c0692b987fd000b3245f28-config.json b/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_da20c9f897d4e5648048577a5c21d81d1237d2f734c0692b987fd000b3245f28-config.json
new file mode 100644
index 0000000..04b3a64
--- /dev/null
+++ b/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_da20c9f897d4e5648048577a5c21d81d1237d2f734c0692b987fd000b3245f28-config.json
@@ -0,0 +1,44 @@
+{
+	"architecture": "amd64",
+	"config": {
+		"AttachStderr": false,
+		"AttachStdin": false,
+		"AttachStdout": false,
+		"Cmd": [
+			"c:\\windows\\system32\\cmd.exe"
+		],
+		"Domainname": "",
+		"Entrypoint": null,
+		"Env": null,
+		"Hostname": "",
+		"Image": "",
+		"Labels": null,
+		"OnBuild": null,
+		"OpenStdin": false,
+		"StdinOnce": false,
+		"Tty": false,
+		"User": "",
+		"Volumes": null,
+		"WorkingDir": ""
+	},
+	"created": "2025-01-13T03:08:16.9200244Z",
+	"history": [
+		{
+			"created": "2024-12-08T22:41:37.6430686Z",
+			"created_by": "Apply image 10.0.26100.2605"
+		},
+		{
+			"created": "2025-01-13T03:08:16.9200244Z",
+			"created_by": "Install update 10.0.26100.2894"
+		}
+	],
+	"os": "windows",
+	"os.version": "10.0.26100.2894",
+	"rootfs": {
+		"diff_ids": [
+			"sha256:6f03bf56adda4553bbee2716396f5b39d873cfdbf24bbe2224ad483e2ea38bbd",
+			"sha256:4fb7d3c0cc9f887880105f122d922670a208321e62b898fe8d2541af7423a658"
+		],
+		"type": "layers"
+	}
+}
diff --git a/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_da20c9f897d4e5648048577a5c21d81d1237d2f734c0692b987fd000b3245f28.json b/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_da20c9f897d4e5648048577a5c21d81d1237d2f734c0692b987fd000b3245f28.json
new file mode 100644
index 0000000..af91ff4
--- /dev/null
+++ b/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_da20c9f897d4e5648048577a5c21d81d1237d2f734c0692b987fd000b3245f28.json
@@ -0,0 +1,21 @@
+{
+	"config": {
+		"digest": "sha256:f21109c0924d0f738e16c937ba525079968c51462480aeb7beb6412d93299615",
+		"mediaType": "application/vnd.docker.container.image.v1+json",
+		"size": 788
+	},
+	"layers": [
+		{
+			"digest": "sha256:73f0ab5f35686f0fbefd312f989476a63c4483e89e34c0487549ac7eb98ebb5b",
+			"mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
+			"size": 2155572515
+		},
+		{
+			"digest": "sha256:e16205cfa699ab31943b0afd8cc5da678176f3910e866afe71b1afcf253f67fc",
+			"mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
+			"size": 277091899
+		}
+	],
+	"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
+	"schemaVersion": 2
+}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant