Remove quoting from adapter: in database.yml
#356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed now; |
yosifkit
reviewed
Jan 7, 2025
| echo " $var: \"$val\"" >> config/database.yml | ||
| if [ "$var" != 'adapter' ]; then | ||
| # https://github.com/docker-library/redmine/issues/353 🙃 | ||
| val='"'"$val"'"' |
There was a problem hiding this comment.
Suggested change
| val='"'"$val"'"' | |
| val="\"$val\"" |
No strong opinion either way, just curious why not double quotes with escapes?
There was a problem hiding this comment.
Just that the highlight in my editor makes the former easier to see as "double quotes around a variable value" and \ is ugly -- very superficial, and I'm happy to change it if you prefer or think it's easier for others the other way. 👍
yosifkit
approved these changes
Jan 15, 2025
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 15, 2025
Changes: - docker-library/redmine@2ac7919: Merge pull request docker-library/redmine#356 from infosiftr/double-quoted-adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353
This still needs testing -- ideally we'd add some automated tests, maybe even for all our supported database adapters, but that's not totally trivial.
(I have something locally for MySQL that I apparently was working on back in 2021, but it doesn't run successfully right now regardless of the issue this fixes, and I have no memory of writing it. 😂)