Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify gemrc nodoc #487

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

Earlopain
Copy link
Contributor

Per https://stackoverflow.com/questions/1381725/how-to-make-no-ri-no-rdoc-the-default-for-gem-install#comment22636260_7662245 this is possible since rubygems 2.0.0 from 2012.

I updated the comment to indicate this is only for the gem command, bundler already doesn't do this by default.

It works (no Parsing documentation...):

$ gem install rubocop -v 1.69.0
Fetching rubocop-1.69.0.gem
Successfully installed rubocop-1.69.0
1 gem installed
$ gem update rubocop
Updating installed gems
Updating rubocop
Fetching rubocop-1.69.1.gem
Successfully installed rubocop-1.69.1
Gems updated: rubocop

Per https://stackoverflow.com/questions/1381725/how-to-make-no-ri-no-rdoc-the-default-for-gem-install#comment22636260_7662245
this is possible since rubygems 2.0.0 from 2012.

I updated the comment to indicate this is only for the `gem` command,
bundler already doesn't do this by default.

It works:
```
$ gem install rubocop -v 1.69.0
Fetching rubocop-1.69.0.gem
Successfully installed rubocop-1.69.0
1 gem installed
$ gem update rubocop
Updating installed gems
Updating rubocop
Fetching rubocop-1.69.1.gem
Successfully installed rubocop-1.69.1
Gems updated: rubocop
```
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@tianon tianon merged commit 4ea77c4 into docker-library:master Dec 6, 2024
26 checks passed
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 7, 2024
Changes:

- docker-library/ruby@4ea77c4: Merge pull request docker-library/ruby#487 from Earlopain/no-doc-simplify
- docker-library/ruby@7806540: Simplify gemrc nodoc
@Earlopain Earlopain deleted the no-doc-simplify branch December 9, 2024 11:41
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 12, 2024
Changes:

- docker-library/ruby@34da3c2: Update 3.4-rc to 3.4.0-rc1
- docker-library/ruby@4ea77c4: Merge pull request docker-library/ruby#487 from Earlopain/no-doc-simplify
- docker-library/ruby@7806540: Simplify gemrc nodoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants