Fix for requests 2.32 #3257
Merged
Fix for requests 2.32 #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
force-pushed
the
requests-hotfix
branch
from
f579f6a
to
b80bfbf
Compare
|
The CI failures seem to be unrelated. |
This was referenced May 21, 2024
jmsanders
added a commit
to dagster-io/dagster
that referenced
this pull request
May 21, 2024
Both docker-py and requests have fixes in flight. We can narrow our pin to only exclude the breaking version. docker/docker-py#3257 psf/requests#6707 (comment)
|
This will need to get updated for psf/requests#6707 (comment). Once that one is finalized I'll update the PR. |
|
I've updated it to be compatible with requests 2.32.2+, which will include psf/requests#6710. |
nateprewitt
reviewed
May 21, 2024
docker/transport/basehttpadapter.py
Outdated
| # https://github.com/psf/requests/commit/c0813a2d910ea6b4f8438b91d315b8d181302356 | ||
| # changes requests.adapters.HTTPAdapter to no longer call get_connection() from | ||
| # send(), but instead call _get_connection(). | ||
| def _get_connection(self, request, *args, proxies=None, **kwargs): |
There was a problem hiding this comment.
I'll be yanking 2.32.0 and 2.32.1 once we get 2.32.2 out so this can probably be omitted from the patch.
There was a problem hiding this comment.
I've removed these lines. (For everyone else: now 2.32.2 is out, and 2.23.0 and 23.2.1 have been yanked.)
There was a problem hiding this comment.
you mean 2.32.0 and 2.32.1 yanked? I still got it installed as an indirect pip dependency just an hour ago.
There was a problem hiding this comment.
Caching perhaps. You can see here they are yanked: https://pypi.org/project/requests/#history.
3 tasks
|
@felixfontein I'm away from my pc right now, but just to be clear: this would be a fix for requests versions 2.32.2 and up, correct? maybe it's also worth updating the dependency definition in pyproject.yaml to avoid accidentally using 2.32.0-2.32.1, if they would still be problematic versions |
4 tasks
maxhoesel
added a commit
to maxhoesel-ansible/ansible-collection-smallstep
that referenced
this pull request
Jun 5, 2024
After yet another breaking package update (docker/docker-py#3257), its high time we permanently pin all development packages *and their dependencies* to a known.-good version. pip-tools lets us do that without losing the simple requirements.txt file that allows easy installation, so lets use that.
maxhoesel
added a commit
to maxhoesel-ansible/ansible-collection-smallstep
that referenced
this pull request
Jun 5, 2024
After yet another breaking package update (docker/docker-py#3257), its high time we permanently pin all development packages *and their dependencies* to a known.-good version. pip-tools lets us do that without losing the simple requirements.txt file that allows easy installation, so lets use that.
maxhoesel
added a commit
to maxhoesel-ansible/ansible-collection-smallstep
that referenced
this pull request
Jun 6, 2024
* lock transitive python dependencies with pip-tools After yet another breaking package update (docker/docker-py#3257), its high time we permanently pin all development packages *and their dependencies* to a known.-good version. pip-tools lets us do that without losing the simple requirements.txt file that allows easy installation, so lets use that. * rework testing harness for py12, remove pytest-virtualenv dep a little while ago, we were starting to get "imp" import errors in CI builds, which I initially were assumed to be from pytest. In fact, it was the pytest-virtualenv package that we used to generate a virtualenv with a specific ansible version for tests. As there is no easy replacement for this package, and the package itself is stale (no release in 5 years), the testing harness now just installs the desired version of ansible-core straight into the main devel virtualenv. This is a bit ugly as it could interfere with other user tasks, but it leaves the interface the same and helps simplify the test fixture code. Said code also now reliably isolates tes environments from another and the user-wide collections. Combined with package pinning introduced in the previous commit, we should no longer have CI failures due to packages or their deps updating and breaking things.
|
If you found yourself here because you had an error such as:
You can probably resolve it by upgrading your |
1 task
5 tasks
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 19, 2024
Pin version of requests package until issue with Docker is fixed: docker/docker-py#3257 Change-Id: If11768d4a88c6f73622a3404ec3da3d676afb37e GitOrigin-RevId: db02ea992515352fb1e701a76db7b2a57b42cc2c
awelzel
added a commit
to zeek/zeek-benchmarker
that referenced
this pull request
Jul 24, 2024
This is to fix requests 2.32.0 not being compatible with docker 6.1.3,
raising errors like:
api-1 | 172.18.0.1 - - [24/Jul/2024:08:51:03 +0000] "POST /zeek?branch=my-testing ... HTTP/1.1" 200 100 "-" "python-requests/2.31.0"
rq-1 | raise InvalidURL(e, request=request)
rq-1 | requests.exceptions.InvalidURL: Not supported URL scheme http+docker
docker/docker-py#3257 (comment)
bagibence
added a commit
to BeNeuroLab/beneuro_experimental_data_organization
that referenced
this pull request
Jul 24, 2024
…g dependencies installed We ran into this issue when trying to run kilosort through docker: docker/docker-py#3256 Hopefully updating docker-py to 7.1.0 fixes it: docker/docker-py#3257 (comment)
bagibence
added a commit
to BeNeuroLab/beneuro_experimental_data_organization
that referenced
this pull request
Jul 24, 2024
…g dependencies installed (#59) * Update spikeinterface and docker, add workflow to test with processing dependencies installed We ran into this issue when trying to run kilosort through docker: docker/docker-py#3256 Hopefully updating docker-py to 7.1.0 fixes it: docker/docker-py#3257 (comment) * Remove numba as an explicit dependency
17 tasks
17 tasks
felddy
added a commit
to cisagov/cyhy-db
that referenced
this pull request
Aug 26, 2024
dav3r
pushed a commit
to cisagov/cyhy-db
that referenced
this pull request
Aug 26, 2024
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 16, 2024
Pin version of requests package until issue with Docker is fixed: docker/docker-py#3257 Change-Id: I59d4882f47f4288226aaabf27554a0b7f9dfe514 GitOrigin-RevId: b46622d7a9d99dfcad2e073e5b6c07887e80542c
tristan957
added a commit
to tristan957/testcontainers-python
that referenced
this pull request
Oct 17, 2024
This allows testcontainers to work with requests >= 2.32.0. Fixes: testcontainers#717 Link: docker/docker-py#3256 Link: docker/docker-py#3257 Link: docker/docker-py#3256 (comment) Signed-off-by: Tristan Partin <tristan@partin.io>
alexanderankin
pushed a commit
to testcontainers/testcontainers-python
that referenced
this pull request
Oct 23, 2024
This allows testcontainers to work with requests >= 2.32.0. Fixes: #717 Link: docker/docker-py#3256 Link: docker/docker-py#3257 Link: docker/docker-py#3256 (comment) Signed-off-by: Tristan Partin <tristan@partin.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current requests 2.32.0 release breaks Docker SDK for Python (see #3256) due to psf/requests@c0813a2.
That commit makes
send()call_get_connection()instead ofget_connection(). Now the Docker SDK for Python code overwritesget_connection(), but of course doesn't magically overwrite_get_connection()as well...This PR introduces a
BaseHTTPAdapter._get_connection()method that simply callsget_connection().See for example https://github.com/docker/docker-py/blob/main/docker/transport/unixconn.py#L66.
Fixes #3256.