SEAB-5951: Add github codespaces "launch with" url property #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathy-t
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Does this need to be added to secrets manager? If yes, can add a note to the 1.15 release checklist https://github.com/dockstore/dockstore-deploy/wiki/1.15-staging
Good idea, done. |
coverbeck
approved these changes
Nov 2, 2023
svonworl
deleted the
feature/seab-5951/add-github-codespace-launch-with-url
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the GitHub Codespaces "launch with" url property.
Review Instructions
Confirm that the new variable appears in web.yml.template
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5951
Please make sure that you've checked the following before submitting your pull request. Thanks!