Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max connections #253

Closed
wants to merge 3 commits into from
Closed

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Mar 7, 2024

Description
Just try the configuration defaults instead of the hibernate defaults. Full discussion in https://ucsc-cgl.atlassian.net/browse/SEAB-6144

Review Instructions
Try benchmarking in qa

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6144

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.

@denis-yuen denis-yuen self-assigned this Mar 7, 2024
@denis-yuen denis-yuen changed the base branch from develop to hotfix/1.15.1 March 7, 2024 16:54
@denis-yuen denis-yuen marked this pull request as ready for review March 7, 2024 16:55
@denis-yuen denis-yuen requested a review from coverbeck March 7, 2024 16:55
Copy link
Collaborator

@coverbeck coverbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we have enough data to be confident in this value? I am concerned if the TRS tools endpoint get hits a lot, it may end up chewing up too much memory.

It's interesting, I'd only see the Dropwizard/Hiberate default, didn't know there was a different Dropwizard-only default.

@denis-yuen
Copy link
Member Author

Do you think we have enough data to be confident in this value? I am concerned if the TRS tools endpoint get hits a lot, it may end up chewing up too much memory.

I think that's why we have to try some trial and error with the benchmarking.

@denis-yuen
Copy link
Member Author

denis-yuen commented Mar 8, 2024

Interestingly, I found a similar difference with maxWaitForConnection in

# the maximum amount of time to wait on an empty pool before throwing an exception
maxWaitForConnection: 1s
vs https://www.dropwizard.io/en/release-3.0.x/manual/configuration.html

I don't actually know if it is better to instantly fail in this case or to wait, potentially for a new container to spin up if the load is enough

@denis-yuen
Copy link
Member Author

In the end, think it makes more sense just to scale up or down rather than tinker with this, see
dockstore/dockstore#5873

@denis-yuen denis-yuen closed this May 8, 2024
@denis-yuen denis-yuen deleted the more_connections branch May 8, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants