Skip to content

Commit

Permalink
minor fix to log
Browse files Browse the repository at this point in the history
  • Loading branch information
denis-yuen committed Feb 21, 2024
1 parent cd4150f commit 471f5ad
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,6 @@ private void executionMetricsPost(List<RunExecution> workflowExecutionsToSubmit,
try {
extendedGa4GhApi.executionMetricsPost(new ExecutionsRequestBody().runExecutions(workflowExecutionsToSubmit), Partner.TERRA.toString(), sourceUrlTrsInfo.trsId(),
sourceUrlTrsInfo.version(), description);
numberOfExecutionsSubmitted.addAndGet(workflowMetricRecords.size());
} catch (ApiException e) {
if (e.getCode() == HttpStatus.SC_REQUEST_TOO_LONG) {
// One execution is too large, not much that can be done, so log and skip it
Expand All @@ -225,7 +224,10 @@ private void executionMetricsPost(List<RunExecution> workflowExecutionsToSubmit,
String.format("Could not submit execution metrics to Dockstore for workflow %s: %s", sourceUrlTrsInfo,
e.getMessage()), skippedExecutionsCsvPrinter, false);
}
return;

Check warning on line 227 in metricsaggregator/src/main/java/io/dockstore/metricsaggregator/client/cli/TerraMetricsSubmitter.java

View check run for this annotation

Codecov / codecov/patch

metricsaggregator/src/main/java/io/dockstore/metricsaggregator/client/cli/TerraMetricsSubmitter.java#L227

Added line #L227 was not covered by tests
}
// only count if there was no exception
numberOfExecutionsSubmitted.addAndGet(workflowMetricRecords.size());
}

/**
Expand Down

0 comments on commit 471f5ad

Please sign in to comment.