Make constructors protected

dockstore · Jul 7, 2023 · 5496e3a · 5496e3a
1 parent 9f6ad83
commit 5496e3a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/metricsaggregator/src/main/java/io/dockstore/metricsaggregator/Statistics.java b/metricsaggregator/src/main/java/io/dockstore/metricsaggregator/Statistics.java
@@ -12,17 +12,17 @@ public abstract class Statistics<T> {
     private T average;
     private int numberOfDataPoints;
 
-    public Statistics() {
+    protected Statistics() {
     }
 
-    public Statistics(T minimum, T maximum, T average, int numberOfDataPoints) {
+    protected Statistics(T minimum, T maximum, T average, int numberOfDataPoints) {
         this.minimum = minimum;
         this.maximum = maximum;
         this.average = average;
         this.numberOfDataPoints = numberOfDataPoints;
     }
 
-    public Statistics(List<T> dataPoints) {
+    protected Statistics(List<T> dataPoints) {
         this.minimum = calculateMinimum(dataPoints);
         this.maximum = calculateMaximum(dataPoints);
         this.average = calculateAverage(dataPoints);

diff --git a/metricsaggregator/src/main/java/io/dockstore/metricsaggregator/helper/AggregationHelper.java b/metricsaggregator/src/main/java/io/dockstore/metricsaggregator/helper/AggregationHelper.java
@@ -274,7 +274,7 @@ public static Optional<MemoryMetric> getAggregatedMemoryFromExecutions(List<RunE
      * @return
      */
     public static Optional<CostMetric> getAggregatedCost(ExecutionsRequestBody allSubmissions) {
-        // Get aggregated Execution Time metrics that were submitted to Dockstore
+        // Get aggregated cost metrics that were submitted to Dockstore
         List<CostMetric> costMetrics = allSubmissions.getAggregatedExecutions().stream()
                 .map(Metrics::getCost)
                 .filter(Objects::nonNull)