Fix empty ALL metrics

dockstore · Oct 30, 2024 · eef599d · eef599d
1 parent 8542e57
commit eef599d
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/metricsaggregator/src/main/java/io/dockstore/metricsaggregator/helper/AthenaAggregator.java b/metricsaggregator/src/main/java/io/dockstore/metricsaggregator/helper/AthenaAggregator.java
@@ -84,7 +84,14 @@ public Map<String, M> createMetricByPlatform(AthenaTablePartition partition) {
             LOG.error("Could not execute query for partition {}", partition, e);
             return Map.of();
         }
-        return createMetricByPlatform(queryResultRows);
+
+        Map<String, M> metricByPlatform = createMetricByPlatform(queryResultRows);
+        // Check that metrics exist for actual platforms. May end up with metrics for only 'ALL' if there are no executions of that type
+        // because null platform values are coalesced to 'ALL'.
+        if (metricByPlatform.size() == 1 && metricByPlatform.containsKey(Partner.ALL.name())) {
+            return Map.of();
+        }
+        return metricByPlatform;
     }
 
     public void printQuery(AthenaTablePartition partition) {