Remove dockstore-webservice dependency #470
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #470 +/- ##
==============================================
- Coverage 49.52% 27.00% -22.52%
+ Complexity 183 106 -77
==============================================
Files 22 22
Lines 1480 1481 +1
Branches 127 128 +1
==============================================
- Hits 733 400 -333
- Misses 704 1055 +351
+ Partials 43 26 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| <!-- used by toolbackup <exclude>javax.annotation:javax.annotation-api</exclude> --> | ||
| <!-- still used by tooltester <exclude>javax.activation:activation</exclude> --> | ||
| <!-- still used by tooltester <exclude>javax.ws.rs:javax.ws.rs-api</exclude> --> | ||
| <exclude>javax.annotation:javax.annotation-api</exclude> |
|
I found a problem when running the tooltester and metrics aggregator so I removed reviewers and made this PR a draft. Will re-request reviews when it's ready again |
|
When running the metrics aggregator and tool tester locally, they failed. Turns out they need the I ran into a null pointer exception when running workflows on AGC using the tooltester so I added a null check. |
| <artifactId>jackson-module-jaxb-annotations</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| <scope>test</scope> |
toolbackup/pom.xml
Outdated
| @@ -170,12 +170,14 @@ | |||
| <dependency> | |||
| <groupId>com.amazonaws</groupId> | |||
| <artifactId>aws-java-sdk-s3</artifactId> | |||
| <version>1.11.83</version> | |||
There was a problem hiding this comment.
Can use a property for these two to hint to a future developer that either these two are upgraded at once or more likely, deleted at the same time
| @@ -169,37 +166,11 @@ | |||
| </exclusion> | |||
| </exclusions> | |||
| </dependency> | |||
| <dependency> | |||
|
SonarCloud Quality Gate failed.
|
|
Updated the dockstore-core dependency to a tag. Build failed because of the new cwlavro version in the webservice, so I updated the pom to use the cwlavro dependencies from the bom |
Description
Companion webservice PR dockstore/dockstore#5562
This PR removes the dockstore-webservice dependency by only using things from dockstore-common. Note that the metrics-aggegator still uses the dockstore-webservice with the test scope.
I also removed all javax dependencies because I didn't see any imports for them. Looks like javax imports were deleted in #468 when we removed the jenkins functionality. This will remove the need for dockstore/dockstore#5527.
Review Instructions
Tests should pass and the metricsaggregator and tooltester should still be functional. Can try running a command for both the metrics aggregator and tooltester to make sure the JAR works. For the metrics aggregator, could submit validation data using a simple CSV file containing data for one workflow. For the tooltester, could upload metrics.
Issue
dockstore/dockstore#5528
https://ucsc-cgl.atlassian.net/browse/DOCK-2404
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean installin the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)