Aggregate cost metric

[kathy-t]

Description
This PR aggregates the cost metric.

Companion PRs:

• Add cost metric dockstore#5577
• Display cost metric dockstore-ui2#1805

Review Instructions

• Submit a run execution metric that specifies a cost for a workflow. Read this doc for more info if you're unfamiliar with submitting metrics. You must be a curator or admin to be able to submit metrics.
• Perform a release of the metrics aggregator so that the new JAR is in artifactory. View the wiki for how to do this
  • Note to self: release after this is merged so reviewing is easier for the verifier. EDIT: I released the 1.15.0-alpha.6 version of the metrics aggregator on artifactory to be used to verify this PR. It can be found here
• SSM onto the deployer and wget the metrics aggregator JAR from artifactory using the following command:

  wget https://artifacts.oicr.on.ca/artifactory/collab-release/io/dockstore/metricsaggregator/1.15.0-alpha.6/metricsaggregator-1.15.0-alpha.6.jar
  

• Add the Deployer instance's public IP to the WAF's exempted IP set so that the Deployer doesn't get rate limited when running the aggregate-metrics command.
  • Navigate to the EC2 console and click on the Deployer instance. In the Details tab, copy the Public IPv4 address value. Remember this value because you'll be deleting this IP once we're done with the metrics aggregator.
  • Go to the WAF console and click on IP sets on the left hand menu. Make sure that you're in the us-east-2 region.
  • Click on qa-core-ExemptedIPSet and add the Deployer's IP to this set. You may need to append /32 to the end of the IP address
• Aggregate the metrics. View the README for instructions on setting up the config file and running the aggregator.
• Go to the workflow version that you submitted metrics for in the UI and enable the metrics flag. Verify that the cost metric shows up.
• Remove the Deployer's IP address from the WAF's exempted IP set when done verifying.

Issue
SEAB-5625

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

• Check that you pass the basic style checks and unit tests by running mvn clean install in the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)
• Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
• If you are changing dependencies, check with dependabot to ensure you are not introducing new high/critical vulnerabilities
• If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

[codecov]

Codecov Report

Patch coverage: 94.91% and project coverage change: +3.70 🎉

Comparison is base (cdb0c1c) 38.96% compared to head (62c9e7c) 42.66%.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop     #471      +/-   ##
=============================================
+ Coverage      38.96%   42.66%   +3.70%     
- Complexity       143      172      +29     
=============================================
  Files             22       24       +2     
  Lines           1481     1596     +115     
  Branches         128      131       +3     
=============================================
+ Hits             577      681     +104     
- Misses           868      877       +9     
- Partials          36       38       +2     

Flag	Coverage Δ
metricsaggregator	42.66% <94.91%> (+3.70%)	⬆️
toolbackup	32.33% <92.09%> (+5.32%)	⬆️
tooltester	32.33% <92.09%> (+5.32%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ava/io/dockstore/metricsaggregator/Statistics.java	82.97% <84.61%> (-17.03%)	⬇️
...re/metricsaggregator/helper/AggregationHelper.java	92.74% <96.29%> (-0.12%)	⬇️
.../dockstore/metricsaggregator/DoubleStatistics.java	100.00% <100.00%> (ø)
...e/metricsaggregator/MetricsAggregatorS3Client.java	81.81% <100.00%> (+0.42%)	⬆️
...o/dockstore/metricsaggregator/MoneyStatistics.java	100.00% <100.00%> (ø)
...aggregator/client/cli/MetricsAggregatorClient.java	69.30% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[kathy-t]

Changes:

• Based on feedback in Add cost metric dockstore#5577 (comment), changed the aggregation of the cost metrics to use the Java Money library to preserve accuracy. In doing so, I removed the Statistics record and made it an abstract class that is inherited by DoubleStatistics and MoneyStatistics. I thought this was a better approach than adding a bunch of Money specific functions to the Statistics record

[coverbeck]

I did not this existed. :)

[denis-yuen]

Very close, the SonarCloud bug warnings seem worth looking into (basically check whether an optional exists before using it)

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint