Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-5700: set dateExecuted field for RunExecution #472

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

hyunnaye
Copy link
Contributor

@hyunnaye hyunnaye commented Jul 27, 2023

Description
This PR adds the dateExecuted information for the tooltester to upload.

Review Instructions
Review that the dateExecuted field in RunExecuted is correctly set.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5700

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install in the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If you are changing dependencies, check with dependabot to ensure you are not introducing new high/critical vulnerabilities
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -10.36% ⚠️

Comparison is base (d82c92b) 42.66% compared to head (2c044ef) 32.31%.

❗ Current head 2c044ef differs from pull request most recent head 07af7fd. Consider uploading reports for the commit 07af7fd to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             develop     #472       +/-   ##
==============================================
- Coverage      42.66%   32.31%   -10.36%     
+ Complexity       172      140       -32     
==============================================
  Files             24       24               
  Lines           1596     1597        +1     
  Branches         131      131               
==============================================
- Hits             681      516      -165     
- Misses           877     1053      +176     
+ Partials          38       28       -10     
Flag Coverage Δ
metricsaggregator ?
toolbackup ?
tooltester ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ckstore/tooltester/runWorkflow/WorkflowRunner.java 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyunnaye hyunnaye requested a review from kathy-t July 28, 2023 14:29
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@hyunnaye hyunnaye merged commit 7049bbd into develop Jul 31, 2023
5 of 6 checks passed
@hyunnaye hyunnaye deleted the seab-5700-dateExecuted-field branch July 31, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants