minor log fix #485
minor log fix #485
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #485 +/- ##
=============================================
- Coverage 57.13% 57.10% -0.03%
Complexity 304 304
=============================================
Files 32 32
Lines 1990 1991 +1
Branches 167 167
=============================================
Hits 1137 1137
- Misses 779 780 +1
Partials 74 74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -199,7 +199,6 @@ private void executionMetricsPost(List<RunExecution> workflowExecutionsToSubmit, | |||
| try { | |||
| extendedGa4GhApi.executionMetricsPost(new ExecutionsRequestBody().runExecutions(workflowExecutionsToSubmit), Partner.TERRA.toString(), sourceUrlTrsInfo.trsId(), | |||
| sourceUrlTrsInfo.version(), description); | |||
| numberOfExecutionsSubmitted.addAndGet(workflowMetricRecords.size()); | |||
There was a problem hiding this comment.
Hmm, I would think this location would also only count it if there's no exception. I believe the problem is that we're logging the count of workflowMetricRecords which may not be the same as the workflow executions that are being submitted via workflowExecutionsToSubmit.
I think we should add the count of workflowExecutionsToSubmit instead of workflowMetricRecords because the former gets partitioned and contains the accurate count
There was a problem hiding this comment.
Oops, totally missed this and makes sense
|
denis-yuen
requested review from
a team,
david4096,
ll5zh and
coverbeck
and removed request for
a team
Description
Iterate version and minor fix to logging (do not increment count if submissions failed)
Review Instructions
When ingesting new metrics, should see more accurate count. May need to wait for more data
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6218
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean installin the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)