-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do some JIRA/GitHub version syncing #495
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #495 +/- ##
==========================================
Coverage 45.70% 45.70%
Complexity 319 319
==========================================
Files 50 50
Lines 2700 2700
Branches 210 210
==========================================
Hits 1234 1234
Misses 1375 1375
Partials 91 91
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
jira_automation/src/main/java/io/dockstore/jira/MilestoneResolver.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review instructions not updated
jira_automation/src/main/java/io/dockstore/jira/MilestoneResolver.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still missing review instructions, something may have gone awry with the way develop was merged into this branch.
topicgenerator/src/main/java/io/dockstore/topicgenerator/client/cli/TopicGeneratorClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise looks fine, but should clean-up before merge
Was here, but the diffs look busted, there's lots of changes in there that probably don't relate to yours. Will take another look when it's fixed. |
4e54899
to
08f4c91
Compare
I had rebased off an older pull of develop. I updated develop locally and rebased again. Diff should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still missing review instructions
jira_automation/src/main/java/io/dockstore/jira/MilestoneResolver.java
Outdated
Show resolved
Hide resolved
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Description
Does some syncing of JIRA fix version and GitHub milestone, which Unito does not do.
The syncing problem is because a fix version in JIRA is a multi-value field, whereas the milestone in GitHub is a single-value field.
See JavaDoc in MilestoneResolver.java for further details.
Review Instructions
Describe if this ticket needs review and if so, how one may go about it in qa and/or staging environments.
For example, a ticket based on Security Hub, Snyk, or Dependabot may not need review since those services
will generate new warnings if the issue has not been resolved properly. On the other hand, an infrastructure
ticket that results in visible changes to the end-user will definitely require review.
Many tickets will likely be between these two extremes, so some judgement may be required.
Issue
SEAB-5953
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install
in the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)